fix: use the correct OCI registry environment variables for newer hosts #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In wasmCloud 0.81.0 we deprecated the old `OCI_REGISTRY` variables in favor of prefixing them with `WASMCLOUD`. 0.82.0 fully removed those variables, so this updates the controller to use the new variables with an eye towards wasmCloud 1.0 compatibility. Signed-off-by: Dan Norris <protochron@users.noreply.github.com>
protochron
force-pushed
the
fix_oci_vars
branch
from
c3ad00f
to
debadb3
Compare
joonas
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
In wasmCloud 0.81.0 we deprecated the old
OCI_REGISTRYvariables in favor of prefixing them withWASMCLOUD. 0.82.0 fully removed those variables, so this updates the controller to use the new variables with an eye towards wasmCloud 1.0 compatibility.Related Issues
Release Information
next
Consumer Impact
This removes support for hosts < 0.81.0 using custom registries, which should be fine.
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification